Improve axis tick increment #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice improvements! This fixes the -0% in most cases? What's up with the 55 in this case? |
I think so.
There is a number formatting bug related to d3 v3 where passing 0.55 to And that one would be fixed if/when we could switch to use latest |
alexcjohnson
reviewed
Sep 2, 2020
alexcjohnson
reviewed
Sep 2, 2020
|
@archmoj this looks good - just a couple of comments to keep performance high ( |
alexcjohnson
approved these changes
Sep 2, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3814 and fixes #5069.
Supersedes #4070.
Demo 1: Before vs After
Demo2: Before vs After
@plotly/plotly_js