Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Drop period positioning for all histogram traces #5175

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Drop period positioning for all histogram traces #5175

merged 2 commits into from
Sep 29, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Sep 29, 2020 •
edited
Loading

b49da24 addresses #5074 (comment).

1046406 drops (x|y)period* attributes added in #5074 as one could use bin.(start|end|size) instead.

@plotly/plotly_js

@archmoj archmoj added bug something broken and removed type: maintenance labels Sep 29, 2020
@archmoj archmoj changed the title Improve labels in histogram2dcontour baseline Drop period positioning for all histogram traces Sep 29, 2020
@archmoj archmoj added this to the v1.56.0 milestone Sep 29, 2020
alexcjohnson
alexcjohnson approved these changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - thanks! 💃

@archmoj archmoj merged commit 38e528e into master Sep 29, 2020
@archmoj archmoj deleted the fixup-period-mock branch September 29, 2020 20:40
This was referenced Sep 29, 2020
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.56.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson