Excluding regl based traces from the strict bundle #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module.exports = function makeWatchifiedBundle(onFirstBundleCallback) { | ||
| var b = browserify(constants.pathToPlotlyIndex, { | ||
| module.exports = function makeWatchifiedBundle(strict, onFirstBundleCallback) { | ||
| var b = browserify(strict ? constants.pathToPlotlyStrict : constants.pathToPlotlyIndex, { |
There was a problem hiding this comment.
Non-blocking, but do we actually want the strict dashboard to use the strict bundle? I'd kind of think we want the full bundle there, or at least have that capability, in order to test which of the full set of traces and features work.
There was a problem hiding this comment.
That could become an option to 'npm start'.
This was referenced Jul 30, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started a "strict"
test_dashboardto help identify which traces may not be rendered when there are certain Content-Security-Policy on the page (e.g. to disallow dynamic function constructors).For now a
Function.applycall in regl dependency stopped by CSP resulting inparcoords,splom,scatterglandscatterpolarglnot being rendered. Therefore these traces would be excluded from plolty.js-strict until #897 could be addressed.@plotly/plotly_js