Skip to content

Fix #7387: Specify buffers in regl.clear() to avoid performance warning #7390

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MzyzzG
Copy link

@MzyzzG MzyzzG commented Mar 16, 2025

This PR fixes issue #7387 by specifying the color and depth buffers in the regl.clear() call in src/traces/scattergl/plot.js. This prevents the "Performance warning: clear() called with no buffers in bitmask" warning.

Changes:

  • Modified regl.clear({}) to regl.clear({ color: true, depth: true }).

@gvwilson gvwilson added feature something new community community contribution P2 considered for next cycle labels Mar 17, 2025
@archmoj
Copy link
Contributor

archmoj commented Apr 3, 2025

This PR looks good to me.
💯 🙏 Many thanks @zachchan-voltaiq
Thanks to @emilykl's #7396 and in order for the failing tests to pass you could fetch upstream/master and merge it into your PR branch.

Please add a draft log as described here: https://github.com/plotly/plotly.js/tree/master/draftlogs

Also it would be great if you add a jasmine test possibly in test/jasmine/tests/scattergl_test.js to lock the bug you fixed in this PR.

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants