Skip to content

Acepace remove future #4951

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

acepace
Copy link

@acepace acepace commented Dec 21, 2024

This removes some dead code, starting with the low hanging fruit mentioned in #4817

Playing around with the zip imports but it's not PR ready yet.

Ace Pace added 3 commits December 21, 2024 21:43
The future is now, has been now for quite a few years

Signed-off-by: Ace Pace <acepace@gmail.com>
Plotly supports only 3.8 and up

Signed-off-by: Ace Pace <acepace@gmail.com>
This is never imported or used

Signed-off-by: Ace Pace <acepace@gmail.com>
@gvwilson gvwilson added feature something new community community contribution labels Jan 3, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Jan 3, 2025

@emilykl can you please have a look at this as part of the plotly.py repo cleanup work?

@acepaceNS
Copy link

Can anyone check on this?

@gvwilson
Copy link
Contributor

Thanks for the PR @acepace - we're hoping to merge #4978 this week, which goes further toward removing out-of-date code in order to shrink the plotly.py bundle size. If you have time to look over the changes in ./codegen and ./_plotly_utils I'd be very grateful for feedback. Thanks - @gvwilson

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community community contribution feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants