Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change Contours size to be f64 instead of usize #245

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

rmburg
Copy link
Contributor

@rmburg rmburg commented Nov 12, 2024

Without this, the intervals between contour lines can only be integers.
I needed a smaller interval for a figure.

To Do:

  • Update changelog

@rmburg
Copy link
Contributor Author

rmburg commented Nov 12, 2024

I added this under a new minor version in CHANGELOG.md, since it is a breaking change. Let me know if this should be changed.

@andrei-ng
Copy link
Collaborator

Yes please (although I find it annoying that we need to bump the major number for such small changes, we night make other ppl unhappy 😁 )

Could you fix the tests as well please 🙏.

@andrei-ng andrei-ng merged commit 80cf0de into plotly:main Nov 12, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants