-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix book chart rendering for basic charts #250
Conversation
@Nick-Pearson , thanks for the PR. Will check it by the end of this week. At a quick glance it looks great 😃 |
// colored_and_styled_scatter_plot(); | ||
// large_data_sets(); | ||
// categories_scatter_chart(); | ||
write_example_to_html(simple_scatter_plot(false), "simple_scatter_plot"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was a nicer way we could achieve this, but I think it is a small price to pay for the benefit of having the examples are compiled and baked in the book.
@Nick-Pearson Going to merge this in. If you are willing to do the rest of the examples, that would be awesome. I am going to check in the meantime if using the |
Thanks @andrei-ng This GitHub action was a jumping off point so it would be good to improve this process further. |
Great! Looking forward to the next PRs :) |
First set of changes for #248
Here you can see the updated github site hosted under my own user account https://npearson.co.uk/plotly.rs/content/recipes/basic_charts/scatter_plots.html
#include
to reference the latest rendered fileIf this approach is ok then I will do the other kinds of graph in the book