Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use plotly-dist as peer dep to fix import issues #94

Closed
wants to merge 1 commit into from
Closed

Use plotly-dist as peer dep to fix import issues #94

wants to merge 1 commit into from

Conversation

m90
Copy link

@m90 m90 commented Aug 12, 2018

This would fix #93 although I'm slightly worried if this would require a (possibly unwanted) new major version.

@nicolaskruchten
Copy link
Contributor

In principle this should work, but so should the current setup with the peer dependency on plotly.js ... We have apps that happily load from plotly.js/dist/plotly and I'm not sure what's happening over in #93 ...

@m90
Copy link
Author

m90 commented Aug 13, 2018

There must be some module resolve voodoo going wrong when using the non-bundled dist version. I don't know too much about the plotly.js internals, so I can only surmise things here. In any case it's most likely an issue with plotly.js instead of react-plotly.js.

The really strange thing about it is that it seems to bundle fine with Webpack, whereas Browserify starts choking.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Gulp "Cannot find module"
2 participants