Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add config option for WebSockets port #51

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Add config option for WebSockets port #51

merged 1 commit into from
Jan 14, 2016

Conversation

arowla
Copy link
Contributor

@arowla arowla commented Dec 10, 2015

At 18F, we were recently playing around with deploying the mozaik-demo on https://cloud.gov. Our hosting environment requires that WebSockets be served on a port other than 80. This PR adds an option to configure that port.

ws = new WebSocket(`${ proto }://${ window.document.location.host }`);
var port = 80;
if (config.wsPort > 0) {
port = config.wsPort;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mozaïk code base uses 4 spaces indent

@plouc
Copy link
Owner

plouc commented Jan 6, 2016

@arowla, sorry for the late review and thank you for your contribution!

@phw phw mentioned this pull request Jan 13, 2016
plouc pushed a commit that referenced this pull request Jan 14, 2016
Add config option for WebSockets port
@plouc plouc merged commit 1d81d74 into plouc:master Jan 14, 2016
@plouc
Copy link
Owner

plouc commented Jan 15, 2016

@arowla available in v1.0.10 (host config too)

@plouc
Copy link
Owner

plouc commented Apr 6, 2016

@arowla, I'm about to add a references section on http://mozaik.rocks/; being a side project (in other words, working on it on my spare time :)), it's hard to craft and promote the tool, so I was wondering if I can add a reference to https://18f.gsa.gov/ and if you could say a few words on your experience with it. I hope you won't find this message too annoying, and sorry to use a comment on github for that.

@arowla
Copy link
Contributor Author

arowla commented May 27, 2016

@plouc Sorry to get back to this so late. We experimented with Mozaik, but I'm not sure whether that project ever got wings. I'm now no longer at 18F, so I'm afraid I can't comment beyond that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants