[FIX] Moving the checkArgumentType error to its caller #1168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the PR about the problem I saw in #1167 and #1166
I think that the intended use of the original change I am fixing was to change the warning into an error, since I saw that it generates SEGFAULTs in case of keeping it as
a warning.
But the
plumed_merror
in theKeywords
scope lose the information of having the information of the "culprit action" (and I think thatplumed_merror
is deprecated in favour ofplumed_error
, right?). So I simply changed the->warning
into an->error
to have the name of the action that arises the problemI think this is more a "dev-side" problem than a "user-input" one, but it is still better to state to the user what is the action that may cause the error, since it can be "workarounded" as I did in #1166
checkArgumentType
is only used in a single instance, so I think the modification is safe:Target release
I would like my code to appear in release I ma targetting master but maybe v2.10 may be better?
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests