Role improved

ansible.cfg

@@ -2,4 +2,3 @@
 remote_tmp = /tmp/.ansible-${USER}/tmp
 local_tmp = $HOME/.ansible/tmp
 pipelining=True
-

defaults/main.yml

@@ -1,22 +1,21 @@
 ---
-lxd_apt_stable_repo: yes
-lxd_packages:
-  - lxd
-  - zfsutils-linux
+
+lxd_default_url: unix:/var/snap/lxd/common/lxd/unix.socket
+
 lxd_users: []
 
-lxd_init: yes
+lxd_init: true
 
-#lxc init: default pool
+# lxc init: default pool
 lxd_default_pool_size: 39GB
 lxd_default_pool_driver: zfs
-lxd_default_pool_zfs_acl: 'off' #posixacl, noacl, off
+lxd_default_pool_zfs_acl: 'off'  # posixacl, noacl, off
 lxd_default_pool_config:
   size: '{{ lxd_default_pool_size }}'
   source: /var/lib/lxd/disks/default.img
   zfs.pool_name: default
 
-#lxd init: default bridge
+# lxd init: default bridge
 lxd_default_bridge_ipv4_address: 'auto'
 lxd_default_bridge_config:
   ipv4.nat: 'true'
@@ -48,4 +47,4 @@ lxd_config:
 # Add DNS servers to dhcp
 lxd_prepend_dns: []
 
-lxd_containters: []
+lxd_containers: []

tasks/configure.yml

@@ -1,8 +1,10 @@
 ---
 
 - name: Deploy LXD preseed
-  template: src="{{ lxd_config_preseed }}" dest="/tmp/lxd.preseed"
-  when: lxd_init|default(False)
+  template:
+    src: "{{ lxd_config_preseed }}"
+    dest: "/tmp/lxd.preseed"
+  when: lxd_init|default(false)
   register: lxd_preseed_status
 
 - name: Configure LXD
@@ -14,15 +16,15 @@
 - name: Add LXD DNS to dhcp
   blockinfile:
     dest: /etc/dhcp/dhclient.conf
-    backup: yes
+    backup: true
     block: 'prepend domain-name-servers {{ item }};'
     marker: '#{mark} LXD DNS'
   with_items: '{{ lxd_prepend_dns }}'
   notify: restart networking
 
 - name: Get acl status for default pool
   shell: zfs get acltype default | grep default | awk '{print $3}'
-  when: lxd_default_pool_driver == 'zfs' and lxd_init|default(False)
+  when: lxd_default_pool_driver == 'zfs' and lxd_init|default(false)
   register: lxd_zfs_acl_status
   changed_when: lxd_zfs_acl_status.stdout != lxd_default_pool_zfs_acl
 

tasks/containers.yml

@@ -15,6 +15,7 @@
     config: '{{ item.config | default(omit) }}'
     wait_for_ipv4_addresses: '{{ item.wait_for_ipv4_addresses | default(omit)}}'
     devices: '{{ item.devices | default(omit) }}'
+    url: '{{ item.url| default(lxd_default_url) }}'
   become: '{{ item.become | default(omit) }}'
   become_method: '{{ item.become_method | default(omit) }}'
   become_flags: '{{ item.become_flags | default(omit) }}'

tasks/dependencies.yml

@@ -0,0 +1,9 @@
+---
+
+- name: Install dependencies
+  apt:
+    name: '{{ item }}'
+    update_cache: true
+  with_items:
+    - software-properties-common
+    - snapd

tasks/install.yml

@@ -1,13 +1,23 @@
 ---
-- name: Ensure APT LXD repository (stable)
-  apt_repository: repo='ppa:ubuntu-lxc/lxd-stable' update_cache='yes'
-  when: lxd_apt_stable_repo
 
-- name: Install LXD
-  package: name={{ item }} state=present
-  with_items: '{{ lxd_packages }}'
+- name: Ensure there is no  lxd installed from repo
+  apt:
+    name: '{{ item }}'
+  with_items:
+    - lxd
+    - lxd-client
+
+- name: Install LXD with snap
+  shell: snap install {{ item }}
+  with_items:
+    - lxd --channel=3.0
+    - lxd
+  changed_when: false
 
 - name: Add users to lxd group
-  user: name={{ item }} groups=lxd append=yes
+  user:
+    name: '{{ item }}'
+    groups: lxd
+    append: true
   with_items: '{{ lxd_users }}'
   register: lxd_group_users_status

tasks/main.yml

@@ -1,10 +1,13 @@
 ---
 
-- include: install.yml
+- import_tasks: dependencies.yml
   tags: [lxd, lxd-install]
 
-- include: configure.yml
+- import_tasks: install.yml
+  tags: [lxd, lxd-install]
+
+- import_tasks: configure.yml
   tags: [lxd, lxd-configure]
 
-- include: containers.yml
+- import_tasks: containers.yml
   tags: [lxd, lxd-containers]

tests/Vagrantfile

@@ -11,6 +11,7 @@ Vagrant.configure("2") do |config|
 
   config.vm.provision 'ansible' do |ansible|
     ansible.playbook = 'test.yml'
+    ansible.extra_vars = { ansible_python_interpreter: '/usr/bin/python3' }
   end
 end
 

tests/inventory

@@ -1 +1,2 @@
-localhost ansible_connection=local
+# localhost ansible_connection=local
+lxc ansible_host=10.180.70.93

tests/test.yml

@@ -1,28 +1,38 @@
 ---
 
-- hosts: localhost
-  become: True
+- hosts: all
+  become: true
   roles:
     - role: plumelo.lxd
       lxd_packages: ['lxd']
-      lxd_users: ['travis']
+      lxd_users: ['ubuntu']
       lxd_dns_ipv4: '10.229.31.1'
       lxd_prepend_dns: ['{{ lxd_dns_ipv4 }}']
       lxd_default_bridge_ipv4_address: '{{ lxd_dns_ipv4 }}/24'
       lxd_default_pool_driver: dir
       lxd_default_pool_config: {}
       cloud_config:
+        package_upgrade: true
         manage_etc_hosts: true
+        hostname: xenial
         packages:
           - python
           - acl
           - sudo
+      lxd_user_data: "#cloud-config\n{{ cloud_config|to_yaml(indent=2) }}"
       lxd_containers:
         - name: xenial
-          state: started
-          become_user: travis
           alias: 'x'
           config:
-            user.user-data: "#cloud-config\n{{ cloud_config|combine({'hostname': 'xenial'})|to_yaml(indent=2) }}"
+            security.nesting: 'true'
+            security.privileged: 'true'
+            user.user-data: "{{lxd_user_data}}"
           devices: {}
           timeout: 600
+
+# lxc_config:
+#   security.nesting=true
+#   security.privileged=true
+#   raw.lxc: |-
+#     lxc.apparmor.profile=unconfined
+#     lxc.cgroup.devices.allow=a