Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make it work with newer v8 versions #120

Closed
ayles opened this issue Aug 28, 2019 · 2 comments
Closed

Make it work with newer v8 versions #120

ayles opened this issue Aug 28, 2019 · 2 comments

Comments

@ayles
Copy link

ayles commented Aug 28, 2019

I'm using v8pp with V8 7.7.214, and there is following problems:

convert.hpp line 182:

return value->BooleanValue(isolate->GetCurrentContext()).FromJust();

should be changed to

return value->BooleanValue(isolate);

throw_ex.ipp lines 7 and 13 - .ToLocalChecked() needed.

So it will be cool to add some #if's on V8 version to fix this.
I'm not so deep into V8 and it's change history so I can't do it right =)

@pmed
Copy link
Owner

pmed commented Aug 28, 2019

Hi,

Thanks for the reporting. Yes, that deprecated BooleanValue() overload was removed in V8 7.6 version. I have definitely to fix this.

Duplicates: #117

@pmed
Copy link
Owner

pmed commented Aug 29, 2019

Fixed by @jacobsologub in PR #123

@pmed pmed closed this as completed Aug 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants