We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
I'm using v8pp with V8 7.7.214, and there is following problems:
v8pp
V8 7.7.214
convert.hpp line 182:
return value->BooleanValue(isolate->GetCurrentContext()).FromJust();
should be changed to
return value->BooleanValue(isolate);
throw_ex.ipp lines 7 and 13 - .ToLocalChecked() needed.
throw_ex.ipp lines 7 and 13
.ToLocalChecked()
So it will be cool to add some #if's on V8 version to fix this. I'm not so deep into V8 and it's change history so I can't do it right =)
#if's
The text was updated successfully, but these errors were encountered:
Hi,
Thanks for the reporting. Yes, that deprecated BooleanValue() overload was removed in V8 7.6 version. I have definitely to fix this.
BooleanValue()
Duplicates: #117
Sorry, something went wrong.
Fixed by @jacobsologub in PR #123
No branches or pull requests
I'm using
v8pp
withV8 7.7.214
, and there is following problems:convert.hpp line 182:
should be changed to
throw_ex.ipp lines 7 and 13
-.ToLocalChecked()
needed.So it will be cool to add some
#if's
on V8 version to fix this.I'm not so deep into V8 and it's change history so I can't do it right =)
The text was updated successfully, but these errors were encountered: