Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing compilation error to reflect changes in v8::Value::BooleanValue() #123

Closed
wants to merge 2 commits into from
Closed

Fixing compilation error to reflect changes in v8::Value::BooleanValue() #123

wants to merge 2 commits into from

Conversation

jacobsologub
Copy link
Contributor

No description provided.

@pmed
Copy link
Owner

pmed commented Aug 29, 2019

Hi @jacobsologub,

thank you for the contribution! I've cherry-picked 4ce49ef to merge the fix for #117 onto the master, and then onto the c++17 branch.

@pmed pmed mentioned this pull request Aug 29, 2019
Closed
@pmed pmed closed this Aug 29, 2019
pmed pushed a commit that referenced this pull request Nov 10, 2019
@jacobsologub @pmed
A more future proof major/minor v8 version check inside v8pp::convert…
f2127d3 
…<bool>::from_v8

v8 8.x is around the corner and the current check fails.
Addition to PR #123 to fix issue #117

4ce49ef
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsologub @pmed