-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Is there any way to use v8pp without v8::Isolate data slot? #26
Comments
Well, I was afraid this moment would come :-) I use a data slot in V8 to store a pointer to a list of registered classes Consider a I need to think either how to store |
Storing a shared list of class singletons only when a preprocessor macro `V8PP_ISOLATE_DATA_SLOT` is defined. Otherwise using the singletons list from a static variable inside of `class_instances()` function. It works this way in most cases for Node.js addons, since a native addon depends on another native addon very rarely. In opposite case, developer should define the `V8PP_ISOLATE_DATA_SLOT` macro with the same value in several projects, which all register and use shared classes in v8pp.
@h2so5 I've pushed changes as v1.2.0. Since this version v8pp doesn't use a data slot in |
@pmed Excellent! Thank you for your quick action 😺 |
Store v8pp internal data in a V8 isolate data slot because the test project runs console and file plugins in different shared libraries. Related to issue #26
There is no available v8::Isolate data slot in Electron.
(All the slots are in use.)
https://github.com/electron/electron/blob/28e2058ff108a20dd395ebe5374403381b6d3ff2/atom/browser/node_debugger.cc#L23-L25
The text was updated successfully, but these errors were encountered: