Conversion of std::tuple types #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wflohry, thank you for the contribution! This is great idea, to add tuple conversions to JavaScript array 👍 |
pmed
requested changes
Feb 28, 2021
pmed
added a commit
that referenced
this pull request
Mar 7, 2021
Reusing existing `check_eq()` test helper, implementing only
`std::tuple` printing.
Perform all work in `convert<tuple>::{from_to}_v8_impl()` helpers with
`std::index_sequence` argument for the tuple elements enumerating.
Unified code style, use tabs instead spaces.
see PR #148
pmed
approved these changes
Mar 7, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request would provide support for conversion of std::tuple types. I added tests in
tests/test_convert.cppto verify proper conversion and handling. Feel free to provide change requests and/or edits as needed.Thanks