Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: disable test due to #5641 #5647

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 16, 2023

Disable test ex_libpmem2/TEST5 for pmemcheck/page configuration until a fix is provided for #5641.

Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@intel.com


This change is Reviewable

@grom72 grom72 force-pushed the test-fix-5641 branch 2 times, most recently from 7759896 to 41cf3f0 Compare May 16, 2023 09:54
@janekmi janekmi added this to the 1.13 on GHA milestone May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #5647 (321a12a) into stable-1.13 (5bfd7d9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           stable-1.13    #5647   +/-   ##
============================================
  Coverage        74.25%   74.26%           
============================================
  Files              145      145           
  Lines            22131    22131           
  Branches          3704     3705    +1     
============================================
+ Hits             16433    16435    +2     
+ Misses            5698     5696    -2     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


src/test/ex_libpmem2/TESTS.py line 80 at r1 (raw file):
Nitpick.

XXX Disable the test execution under pmemcheck with g.PAGE until fixed. URL


src/test/ex_libpmem2/TESTS.py line 81 at r1 (raw file):
Nitpick.

to be removed when fixed


src/test/ex_libpmem2/TESTS.py line 94 at r1 (raw file):

# XXX see TEST5 above
@t.require_valgrind_disabled('pmemcheck')
class TEST501(TEST5):  # to be removed when fix available

Are you sure you do not inherit all the decorators from the parent class? 🤔

@grom72 grom72 force-pushed the test-fix-5641 branch 2 times, most recently from 965c6cf to 0fa5389 Compare May 16, 2023 11:15
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @janekmi)


src/test/ex_libpmem2/TESTS.py line 94 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Are you sure you do not inherit all the decorators from the parent class? 🤔

Done.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 merged commit 3959bd8 into pmem:stable-1.13 May 17, 2023
@grom72 grom72 deleted the test-fix-5641 branch May 25, 2023 05:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants