Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid stack usage for big structure like pool_hdr #5889

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Oct 24, 2023

Decrease the amount of stack memory usage by allocating big local data structures (like pool_hdr) on the heap by using the Malloc() function.

Requires:


This change is Reviewable

@grom72 grom72 added libpmemobj src/libpmemobj DAOS DAOS-related sprint goal This pull request is part of the ongoing sprint labels Oct 24, 2023
@grom72 grom72 requested review from janekmi and osalyk October 24, 2023 08:15
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #5889 (074e86d) into master (a08e391) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 85.71%.

❗ Current head 074e86d differs from pull request most recent head 4aed510. Consider uploading reports for the commit 4aed510 to get more accurate results

@@           Coverage Diff           @@
##           master    #5889   +/-   ##
=======================================
  Coverage   71.00%   71.01%           
=======================================
  Files         131      131           
  Lines       19172    19198   +26     
  Branches     3192     3194    +2     
=======================================
+ Hits        13614    13633   +19     
- Misses       5558     5565    +7     

@grom72 grom72 force-pushed the limited-pool_hdr branch 2 times, most recently from 067aa12 to d1f1290 Compare October 24, 2023 13:56
Use Malloc to allocate big local data structure to avoid
stack overusage.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 self-assigned this Oct 30, 2023
@grom72 grom72 marked this pull request as draft October 30, 2023 11:53
@janekmi janekmi removed the sprint goal This pull request is part of the ongoing sprint label Oct 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DAOS DAOS-related libpmemobj src/libpmemobj
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants