Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
run_qemu.sh: drop mkosi --autologin, use systemd credentials instead
Until mkosi v24 commit c236c9f7b9c82d3, `mkosi --autologin` used to be applied to four devices: console, tty1, ttyS0 and one architecture-dependent device. mkosi has some QEMU features of its own to boot the image. run_qemu.sh never used any of that. We should probably try (some of) it in the future but I digress. In that mkosi commit, `mkosi/qemu.py` (which we don't use) stopped using `ttyS0` and replaced it with the faster `/dev/hvc0` instead. The image building code (which we DO use!) was updated correspondingly without caring about backwards compatibility and dropped ttyS0 on the floor. Someone noted this in systemd/mkosi#2834 and the recommendation was to switch to systemd credentials: exactly what this commit does. The mkosi maintainer also expressed the possible removal of `--autologin` in the future. Pros: - Completely removes the autologin dependency on the changing mkosi behavior. Compatible with any mkosi version. - Applies to all terminals, zero hardcoded name. - Simpler, clearer and more direct implementation: zero configuration file! - More dynamic: changes and tests do not require rebuilding anything. Cons: - Requires systemd v251 or above (May 2022) - Applies to all terminals but could be more selective when using "per-instance" systemd credentials added in v257 (December 2024) Signed-off-by: Marc Herbert <marc.herbert@intel.com>
- Loading branch information