Skip to content

Commit

Permalink
Server: stop discriminating against crashes caused by folder plugins
Browse files Browse the repository at this point in the history
these are the de facto standard, which means that a lot of crashes aren't getting reported from servers with folder plugins.
  • Loading branch information
dktapps committed Sep 6, 2023
1 parent 690ee4c commit b160b87
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/Server.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
use pocketmine\player\PlayerDataSaveException;
use pocketmine\player\PlayerInfo;
use pocketmine\plugin\PharPluginLoader;
use pocketmine\plugin\Plugin;
use pocketmine\plugin\PluginEnableOrder;
use pocketmine\plugin\PluginGraylist;
use pocketmine\plugin\PluginManager;
Expand Down Expand Up @@ -1606,15 +1605,6 @@ public function crashDump() : void{
}
@touch($stamp); //update file timestamp

$plugin = $dump->getData()->plugin;
if($plugin !== ""){
$p = $this->pluginManager->getPlugin($plugin);
if($p instanceof Plugin && !($p->getPluginLoader() instanceof PharPluginLoader)){
$this->logger->debug("Not sending crashdump due to caused by non-phar plugin");
$report = false;
}
}

if($dump->getData()->error["type"] === \ParseError::class){
$report = false;
}
Expand Down

0 comments on commit b160b87

Please # to comment.