Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(issues/89): Fixed production build, tests #94

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

gabriellebaudy
Copy link
Contributor

@gabriellebaudy gabriellebaudy commented Jul 7, 2022

  • Fixed this issue by changing how queryBenchmarks is declared.
  • Removed the following code to have tests pass (they did not before):
screen: {
  height: 1668,
  width: 2224,
},

@puckey
Copy link
Collaborator

puckey commented Jul 10, 2022

Thanks for the pull request. Perhaps @TimvanScherpenzeel can take a look at it, since they did the build code?

I wonder what is causing that test to fail though. Pretty sure it was working before. @TimvanScherpenzeel do the data updates run the tests before committing?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught (in promise) TypeError: M is not a function
3 participants