storeHooks minor improvement #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/7RE32AJP8 |
See documentations for usage instructions.
dmaskasky
changed the base branch from
main
to
feat/core/expose-internals-instead-of-derive
dmaskasky
force-pushed
the
store-hooks-3
branch
from
496112b to
d1487e4
Compare
dai-shi
merged commit 7aaf1a9
into
pmndrs:feat/core/expose-internals-instead-of-derive
44 checks passed
dai-shi
added a commit
that referenced
this pull request
Feb 11, 2025
* wip: expose internal functions * rename * tests following the change * separate internals entrypoint * fix entries * fix for umd, still wip * revert them * revert changes * rename readme * internals entry point * impl * fix store test * derive test * effect test * fix rollup config * hack types * fix workflow files * fix workflow files again * hack types again * fix rollup config * ts ignore * tried this? * test: rename * follow the change * I think this is unnecessary * fix AtomState type * do not enumerate secret methods * even better * refactor * another refactor * wip: building-block functions * give up scope tests for now * some more refactors * fix workflow file * use symbol instead of weakmap for cancelable promise * fix typo * expose util and tentative functions * does this fix? * catch error from f hook * only keeps one error * do we want to support falsy errors? * going back the circle * store hook for atoms util * does this help? * for ts3.9 * store hooks tweaks (#2969) * lazy assign store hooks internally * initializeStoreHooks * make it work with node 18 * refactor(internals): isolated mounted map in store (#2967) * refactor(internals): isolated mounted map in store * give up derive test * rev4 compatibility * a silly mistake * storeHooks minor improvement (#2970) * storeHooks: return delete function from add * Update src/vanilla/internals.ts --------- Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com> * refactor(internals): store state in store args (#2972) * refactor(internals): atomStateMap in storeState * store args for everything and create building blocks * createStoreArgs * refactor * refactor and type * export internal types * simplify types * prefer readonly modifier * expose building blocks * elminate store args * expose building blocks (#2974) * expose building blocks * elminate store args * move top-level functions to createBuildingBlocks and add some organization * tweak createBuildingBlocks * update store and tests invocation of INTERNAL_createBuildingBlocks * fix lint and decomposition * refactor(internals): simplify building blocks --------- Co-authored-by: daishi <daishi@axlight.com> * comments * customizable building blocks * ts hack * ts hack 2 * minor change * nice to remove ! * refactor * full building blocks (#2977) * return a complete building blocks array * return mutable building blocks * revert to default function argument style --------- Co-authored-by: daishi <daishi@axlight.com> --------- Co-authored-by: David Maskasky <dmaskasky@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Return delete function from add in storeHooks.
Check List
pnpm run fix:formatfor formatting code and docs