Skip to content

[chore] Recrawl doesn't run on Windows #1459

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
joshuaellis opened this issue Apr 25, 2021 · 9 comments · Fixed by #1379
Closed

[chore] Recrawl doesn't run on Windows #1459

joshuaellis opened this issue Apr 25, 2021 · 9 comments · Fixed by #1379
Assignees
@joshuaellis
Labels
kind: request New feature or request that should be actioned type: good first issue Good for newcomers

Comments

@joshuaellis
Copy link
Member

🚀 Feature Proposal

The recrawl library doesn't actually run on windows, and that's not good for potential maintainers who use windows as they can't build or run tests.

To counteract this, I propose we move to fdir which AFAIK supports windows and Unix machines.
@joshuaellis joshuaellis added kind: request New feature or request that should be actioned type: good first issue Good for newcomers labels Apr 25, 2021
@CodyJasonBennett
Copy link
Member

CodyJasonBennett commented Apr 25, 2021 •
edited
Loading

Although recrawl has promised Windows support with v2.0.1, it still doesn't parse/sanitize paths right (same issue on latest).

I think we go with your proposal, and I'll report this issue to recrawl in case we don't have to migrate.

Edit: This seems to be a known issue, among other things.

@joshuaellis
Copy link
Member Author

@CodyJasonBennett if it doesn't parse paths, does that mean it doesn actually work on windows? 😅

@CodyJasonBennett
Copy link
Member

CodyJasonBennett commented Apr 25, 2021 •
edited
Loading

@joshuaellis, sadly yes. Maybe support means thoughts and prayers?

@CodyJasonBennett
Copy link
Member

It looks like build-if-changed also uses recrawl, with the same issues.

I think we'll have to wait until Windows is better supported.

@joshuaellis
Copy link
Member Author

We were looking at getting rid of bic and lerna and replacing with preconstruct over on #1379 🤔 might be time to push some effort that way....

joshuaellis added a commit that referenced this issue Apr 26, 2021
@joshuaellis
chore: remove recrawl
e838e8f 
resolves #1459
@joshuaellis joshuaellis linked a pull request Apr 26, 2021 that will close this issue
Chore/db v9 preconstruct #1379
Merged
6 tasks
@joshuaellis joshuaellis self-assigned this Apr 27, 2021
joshuaellis added a commit that referenced this issue Apr 27, 2021
@dbismut @joshuaellis
chore: move to preconstruct & changesets (#1379)
c1b9e80 
* chore: move to preconstruct

* chore: use enum for TransitionPhase

* chore: clean overload types

* chore: fix tsconfig to include targets

* chore: add alloc/types back

* chore: remove .bic_cache files

* chore: add class-properties support for babel

* chore: remove devDependencies from packages

* chore: retriggering codesandbox ci with useless comment

* Revert "chore: remove devDependencies from packages"

This reverts commit 3c2dcb4.

* chore: reclean deps

* chore: update yarn.lock

* chore: re-removing devDependencies

* Revert "chore: re-removing devDependencies"

This reverts commit 278c385.

* chore: remove react-spring from deps

* chore: add js files back in

* chore: fix class super property bug

* chore: fix tests

* fix: final test

* refactor: remove eslint

lets do it in another commit and use the same one in drei / r3f etc.

* fix: type tests

* chore: add changesets

* chore: add changelog

* chore: set tidled versions of package for changesets to bump

* chore: add licenses and update packages for npm

* chore: add new scripts for releasing

* chore: add nested CHANGELOG to gitignore

* chore: remove old slow scripts

* chore: remove recrawl

resolves #1459

* chore: remove docs we dont need

* chore: update CONTRIBUTING

* chore: tweak config

Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
@joshuaellis
Copy link
Member Author

@CodyJasonBennett if you try and use beta hopefully you should be able to run everything on windows. Would you be able to test and confirm?

@CodyJasonBennett
Copy link
Member

CodyJasonBennett commented Apr 27, 2021 •
edited
Loading

@joshuaellis, looking over this now.

I'm immediately getting: EPERM: operation not permitted, symlink (full stack-trace). I'm going to make sure everything is fine as far as my filesystem and permissions before looking much further.

@joshuaellis
Copy link
Member Author

Have you seen this? preconstruct/preconstruct#381 (comment)

If this fixes, would you be able to add a small section to the contributing doc about this?

@CodyJasonBennett
Copy link
Member

CodyJasonBennett commented Apr 27, 2021 •
edited
Loading

@joshuaellis, I'm rolling back my changes now, and that looks like a quick fix. I'll add a note in the contributing docs.

Are there any more environments we need to look into? AFAIK, only Windows came to mind.

@CodyJasonBennett CodyJasonBennett mentioned this issue Apr 27, 2021
Merged
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@joshuaellis joshuaellis

Labels
kind: request New feature or request that should be actioned type: good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore/db v9 preconstruct pmndrs/react-spring
2 participants
@CodyJasonBennett @joshuaellis