Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve Logging #19

Closed
pncnmnp opened this issue May 16, 2023 · 1 comment
Closed

Improve Logging #19

pncnmnp opened this issue May 16, 2023 · 1 comment
Assignees
Labels

Comments

@pncnmnp
Copy link
Owner

pncnmnp commented May 16, 2023

The logging system we currently have is quite difficult to read and debug. To address this issue, our first step would be to eliminate the unnecessary noise generated by Coqui-ai's TTS and FFmpeg.

However, it may be challenging to suppress TTS logs as they currently rely on print statements rather than the logging module. To solve this problem, we could use a method similar to the one outlined here: https://stackoverflow.com/a/45669280/7543474 - to remove any excess print statements.

While we don't want to overwhelm the user with too many logs, we still want them to have a clear understanding of the overall flow. Ideally, they should be aware of what is being generated and in what order.

@pncnmnp pncnmnp self-assigned this May 16, 2023
pncnmnp added a commit that referenced this issue May 16, 2023
Suppressed logs from TTS and FFmpeg
as they were adding in noise to the output
pncnmnp added a commit that referenced this issue May 16, 2023
@pncnmnp
Copy link
Owner Author

pncnmnp commented May 16, 2023

Couple of issues to fix:

  • musicbrainzngs.search_recordings are polluting the logs when music-artist action is used.
  • other occurrences of ffmpeg needs to be suppressed as well

pncnmnp added a commit that referenced this issue May 16, 2023
pncnmnp added a commit that referenced this issue May 17, 2023
@pncnmnp pncnmnp closed this as completed May 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant