ARM: disable native assembler optimisations #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change disables assembly of assembler language implementations of ARM Neon optimisations. This only affects older GCC versions; everything else either did nothing or used the GCC "intrinsics". The change can be explicitly bypassed by defined PNG_ARM_NEON_IMPLEMENTATION or, of course, by just reverting the two lines that have material changes! Signed-off-by: John Bowler <jbowler@acm.org>
|
@billatarm, @rossburton: please review. |
|
I think the right approach here is to remove the |
|
Yes; this change is insufficient. See my comments in: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables assembly of assembler language implementations of
ARM Neon optimisations. This only affects older GCC versions;
everything else either did nothing or used the GCC "intrinsics".
The change can be explicitly bypassed by defined
PNG_ARM_NEON_IMPLEMENTATION or, of course, by just reverting the two
lines that have material changes!
Signed-off-by: John Bowler jbowler@acm.org