pngimage: clean up on user/internal errors #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update man page to latest PNG 3e draft
pngimage: The code simply exited with a return code of 99 in the event of a user error including giving pngimage invalid PNG files and an internal error. It now attempts to clean up the state before doing so, matching the normal behaviour. pngimage: Non-ISO use of setjmp(3) corrected. pngerror.c: Failure to call png_image_free on a false result from a png_safe_execute function call fixed. This was a regression caused by the 'volatile' clean-up. Not normally detectable because png_image_free will often be called by the application. Signed-off-by: John Bowler <jbowler@acm.org>
ctruta
approved these changes
Feb 17, 2025
|
Integrated in trunk -- many thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pngimage: The code simply exited with a return code of 99 in the event
of a user error including giving pngimage invalid PNG files and an
internal error. It now attempts to clean up the state before doing so,
matching the normal behaviour.
pngimage: Non-ISO use of setjmp(3) corrected.
pngerror.c: Failure to call png_image_free on a false result from a
png_safe_execute function call fixed. This was a regression caused by
the 'volatile' clean-up. Not normally detectable because png_image_free
will often be called by the application.
Signed-off-by: John Bowler jbowler@acm.org