Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

C90: correct initialisation of ARM SIMD register #661

Open
wants to merge 1 commit into
base: libpng16
Choose a base branch
from

Conversation

jbowler
Copy link
Contributor

@jbowler jbowler commented Feb 22, 2025

arm/palette_neon_intrinsics.c: change the initialisation of the "opaque
black" standard PLTE filler to be in-line rather than using a C99 style
{} initializer which calls functions.

This change also reduces the number of function calls required from 4 to
2.

Signed-off-by: John Bowler jbowler@acm.org

arm/palette_neon_intrinsics.c: change the initialisation of the "opaque
black" standard PLTE filler to be in-line rather than using a C99 style
{} initializer which calls functions.

This change also reduces the number of function calls required from 4 to
2.

Signed-off-by: John Bowler <jbowler@acm.org>
@jbowler
Copy link
Contributor Author

jbowler commented Feb 22, 2025

This removes the remaining C99ism in libpng 1.6. The same issue exists in 1.8 so this can be applied there too (there should be no conflicts) but 1.8 also requires a correction to a C99ism that I accidentally introduced in the same body of code (this won't conflict with this change.)

Tested (successfully) on aarch64, Ubuntu.
Tested partially on armv7a Ubuntu; armv7a is no longer supported by Ubuntu and as a consequence my cross-build of pngvalid will not run because of changes in the glibc DLL.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant