Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates in clang-format config and running scripts #9

Merged
merged 4 commits into from
Mar 22, 2020

Conversation

pniewiejski
Copy link
Owner

No description provided.

- This commit changes the regex used in the find command in the
  script that calls clang-format. This is due to the fact that the
  find command on BSD does not have extened regex out of the box.

  More information here:
  https://stackoverflow.com/questions/5905493/why-isnt-this-regex-working-find-regex-m-h

- Remove `cu` file extension in find regex as it is not used
  in this project.
This removes entries which my version of clang-format (9.0.0) took
as invalid 🤷.
@pniewiejski
Copy link
Owner Author

TODO
Investigate why this error occurs on Mac

➜  luhncpp git:(master) ✗ clang-format -style=file  ./src/luhn.cpp
YAML:97:18: error: Unexpected token. Expected Key or Block End
      Delimiters:
                 ^
Error reading /Users/piotrniewiejski/Code/luhnjs/luhncpp/./.clang-format: Invalid argument
➜  luhncpp git:(clang-format-update) clang --version
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin19.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
➜  luhncpp git:(clang-format-update) clang-format --version
clang-format version 9.0.0 (tags/google/stable/2019-05-14)
➜  luhncpp git:(clang-format-update)

I'm removing this entry as it does not make much of a difference here (removed in 9a3ae03).

@pniewiejski pniewiejski merged commit b140749 into master Mar 22, 2020
@pniewiejski pniewiejski deleted the clang-format-update branch March 22, 2020 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant