Fix for IsFeatureActiveInternal when Feature does not exist for the Template #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 24, 2021 14:45
…rverObjectIsNull =null and fail
…ture only when not a TEAMCHANNEL
…e Feature on TEAMCHANNEL Sites. However - this specific case is avoided by a check in IsCommunicationSite
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix avoids crash when IsCommunicationSite is called for a TEAMCHANNEL Site where that feature is unkown.
In case of other such issues we try/catch and log the error in IsFeatureActiveInternal as an Error