Fixing issue when trying to export datarow for list instances #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue in the code that is preventing to export properties for files from libraries when there are several content types. Not sure if affects to more cases. In line 587, code is adding ContentTypeId to the pnpFile.Properties. In line 613, was trying to add again the same property key to the dictionary, that was raising an issue. Changing the way to add properties to the dictionary, it will overwrite it if exists.
|
Good change @magarma , thanks for helping make PnP Provisioning better 💗 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in the code that is preventing to export properties for files from libraries when there are several content types.
Not sure if affects to more cases.
In line 587, code is adding ContentTypeId to the pnpFile.Properties. In line 613, was trying to add again the same property key to the dictionary, that was raising an issue.
Changing the way to add properties to the dictionary, it will overwrite it if exists.