Fix issue when folderpath doesn't start by '/' #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When container doesn't start with '/' , doing the string.Concat was building the wrong path
'{Path_Returned_By_GetContainer}{container}' instead of '{Path_Returned_By_GetContainer}/{container}'
Using Path combine we avoid that issue
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in ClientSidePageContentHelper that happens when a container doesn't start with '/'.
The string.Concat is building the wrong path '{Path_Returned_By_GetContainer}{container}' instead of '{Path_Returned_By_GetContainer}/{container}'.
Using Path combine we avoid that issue
For instance... you can see how that part of the code creates that wrong path {Guid}SiteAssets instead of {Guid}/SiteAssets