Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added ignoreDefaultProperties to UsersUtility #590

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

KoenZomers
Copy link
Contributor

Added ignoreDefaultProperties optional parameter to methods in UsersUtility.cs class to allow the default parameters not to be queried for. Used by pnp/powershell#1575.

@KoenZomers KoenZomers changed the title Added ignoreDefaultProperties optional parameter Added ignoreDefaultProperties to UsersUtility Jan 28, 2022
@jansenbe
Copy link
Contributor

jansenbe commented Feb 7, 2022

@KoenZomers : can you have a look at this PR as there are code review comments + the PR has merge conflicts after merging your previous PR. Thx.

@KoenZomers
Copy link
Contributor Author

@jansenbe Done!

@jansenbe
Copy link
Contributor

jansenbe commented Feb 8, 2022

@KoenZomers : I think it's still not OK as the ignoreDefaultProperties is not passed into the ListUsers method, so there little point of adding them to those overrides...ping me if needed so we can have a quick chat

@KoenZomers
Copy link
Contributor Author

@jansenbe I've added back the missing code. Should be good now.

@jansenbe jansenbe merged commit 14b0695 into pnp:dev Feb 11, 2022
jansenbe added a commit that referenced this pull request Feb 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants