Skip to content

[BUG] Latest version in version check is nightly and not stable one #4408

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
5 tasks
tivanchuk-hawe opened this issue Oct 9, 2024 · 2 comments · Fixed by #4453
Closed
5 tasks

[BUG] Latest version in version check is nightly and not stable one #4408

tivanchuk-hawe opened this issue Oct 9, 2024 · 2 comments · Fixed by #4453
Labels
bug Something isn't working pending team discussion Item needs to be discussed in the team meeting first before we can proceed

Comments

@tivanchuk-hawe
Copy link

tivanchuk-hawe commented Oct 9, 2024

Reporting an Issue or Missing Feature

In latest stable release https://github.com/pnp/powershell/releases/tag/v2.12.0 was changed
"Removed version check dependency on version.txt located in Github repo. Use metadata from powershellgallery.com instead."
This is OK, but now (unlike previously, check the version history) there are nightly versions in PS Gallery, so when you check there the latest version it shows nightly one.
image

Possible solutions as I see them:
(either or)

  1. use prerelease for nightly + update check ignores alpha, beta ones
  2. Nightly isn't posted in PS Gallery anymore => check will work as expected after the next stable release
  3. If you keep posting nightly in PS Gallery w/o 1st - probably the check should be changed back

Expected behavior

Nightly isn't shown on new version check

Actual behavior

Update check shows latest nightly version

Steps to reproduce behavior

  1. Installed 2.12.0
  2. Connect-PnPOnline
  3. warning will shown

What is the version of the Cmdlet module you are running?

2.12.0

Which operating system/environment are you running PnP PowerShell on?

  • [ x] Windows
  • Linux
  • MacOS
  • Azure Cloud Shell
  • Azure Functions
  • Other : please specify
@tivanchuk-hawe tivanchuk-hawe added the bug Something isn't working label Oct 9, 2024
@ddouden
Copy link

ddouden commented Oct 10, 2024

Same issue here, running the stable version.
@erwinvanhunen On PSGallery the 2.99.8-nightly version is shown as the current version.

https://www.powershellgallery.com/packages/PnP.PowerShell/2.99.8-nightly

@KoenZomers
Copy link
Collaborator

Correct. I can reproduce this and found the issue. Thanks for reporting it.

@KoenZomers KoenZomers self-assigned this Oct 11, 2024
@KoenZomers KoenZomers added the pending team discussion Item needs to be discussed in the team meeting first before we can proceed label Oct 11, 2024
@KoenZomers KoenZomers removed their assignment Oct 11, 2024
jackpoz added a commit to jackpoz/powershell that referenced this issue Oct 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working pending team discussion Item needs to be discussed in the team meeting first before we can proceed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants