Skip to content

Feature: Added support for HTTP/2 to improve perf #2687

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Jan 17, 2023

Conversation

gautamdsheth
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

NA

What is in this Pull Request ?

Added HTTP/2 support for all HTTP requests to improve performance.
It will by default fallback to 1.1 if the server doesn't support.

@KoenZomers
Copy link
Collaborator

Tested this PR. When I execute i.e. Get-PnPMicrosoft365Group, I see it has HTTP 2.0 in the requestmessage. Fiddler however shows a normal HTTP 1.1 connection is being made:

image

image

Is that as expected? What would make the code ask the server for HTTP 2.0 I'm wondering?

@KoenZomers
Copy link
Collaborator

No issues from my current machine. Must have been a connection issue. Going to proceed with merging.

@KoenZomers KoenZomers merged commit 63e65b0 into pnp:dev Jan 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants