Skip to content

Change Set-PnPWebhookSubscription to use the same defualt expiration date as Add-PnPWebhookSubsription #3106

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 17, 2023

Conversation

reusto
Copy link
Contributor

@reusto reusto commented May 12, 2023

…kSubscription

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

What is in this Pull Request ?

Update to Set-PnPWebhookSubscription to use the same default expiration data as Add-PnPWebhookSubscription.
This resolves a potential issue where 6 months - 72 hours > 180 days which would return an error from the API. (see: https://learn.microsoft.com/en-us/sharepoint/dev/apis/webhooks/overview-sharepoint-webhooks#expiration)

Summary

copilot:summary

Details

copilot:walkthrough

@gautamdsheth gautamdsheth merged commit 34736dd into pnp:dev May 17, 2023
@gautamdsheth
Copy link
Collaborator

Good catch, thanks @reusto !!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants