Skip to content

Fix bug #3350 Do not display access token #3352

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

ryder-cayden
Copy link

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Issue #3350

What is in this Pull Request ?

Remove the code where the access token is being displayed on screen as it poses security risks

@KoenZomers
Copy link
Collaborator

Thanks @ryder-cayden for proposing the change. It was a deliberate change in the previous version to aid in troubleshooting, but I understand the concerns. Just know that Get-PnPAccessToken will also reveal it as well as sniffing your network traffic using i.e. Fiddler. I understand the concern if you're running everything in verbose and logging it to disk, that it might oppose a security risk, so will proceed with merging this change.

@KoenZomers KoenZomers merged commit 3a6bb1c into pnp:dev Sep 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants