feat: support package.yaml
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
zkochan
reviewed
Feb 6, 2025
| @@ -49,7 +50,11 @@ async function readTarget(opts: { | |||
|
|
|||
| if (GITHUB_WORKSPACE) { | |||
| try { | |||
| ({ packageManager } = JSON.parse(readFileSync(path.join(GITHUB_WORKSPACE, packageJsonFile), 'utf8'))) | |||
| const content = readFileSync(path.join(GITHUB_WORKSPACE, packageJsonFile), 'utf8'); | |||
There was a problem hiding this comment.
it is confusing that packageJsonFile can be a yaml
There was a problem hiding this comment.
it is confusing that packageJsonFile can be a yaml
What do you suggest? @zkochan Rename all instances to packageFile?
There was a problem hiding this comment.
We could rename the setting to package_file or manifest_file but the feature will be rarely used, so I don't think it is worth a breaking change
There was a problem hiding this comment.
I don't think it is worth a breaking change
Maybe just a note in the README then?
zkochan
approved these changes
Feb 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pnpm/pnpm#1100 and pnpm/pnpm#1799.