Add edge-case for DataGranule section #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cleaning UMM-G json, we have to specially handle the ‘DataGranule > Identifiers’ section, as both type and value entries are required for all identifiers.
ngachung
approved these changes
May 27, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning up UMM-G json, we have to specially handle the ‘DataGranule > Identifiers’ section, specifically:
For the Identifiers array to be included there must be at least one 'complete' array entry.
A complete entry requires both 'IdentifierType' and 'Identifier' fields, and the type must match a controlled vocabulary.
So, if we're missing either field, for any Identifier array element, remove it from the array, and if we end up with an empty array, remove the Identifiers section entirely.