Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/issue 3 #11

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Feature/issue 3 #11

merged 3 commits into from
Oct 18, 2023

Conversation

torimcd
Copy link
Collaborator

@torimcd torimcd commented Oct 18, 2023

Github Issue: #3

Summarize the ticket here

Support scrambling SWOT data values during database loading to support public beta testing without exposing real measurements before public release.

Summarize the work you did

Added configuration argument to obscure data, modified read_shapefile function to implement scaling by a random integer on appropriate data columns, added new unit test.
Also made minor modifications to API data access module and testing fixtures to have unit tests work on both API and DB after merging repos so all unit tests pass.

Summarize the testing and verification you've done. This includes unit tests or testing with specific data

Added unit test for data scrambling, modified dynamodb fixtures to support both API and DB modules in combined repository. All unit tests pass.

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

Linted
Updated unit tests
Updated changelog
Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@torimcd
Copy link
Collaborator Author

torimcd commented Oct 18, 2023

@frankinspace please review

@frankinspace frankinspace merged commit d78cb4d into develop Oct 18, 2023
@frankinspace frankinspace deleted the feature/issue-3 branch October 18, 2023 22:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants