Feature/issue 39 #68
Merged
Feature/issue 39 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankinspace
requested changes
Dec 19, 2023
Do you want me to put them all back? most of them are a bit unnecessary, the code is kind of self explanatory. But I can put them back if you think they help with code maintenance. |
frankinspace
requested changes
Dec 19, 2023
torimcd
approved these changes
Dec 22, 2023
frankinspace
approved these changes
Jan 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #39
Description
Clean up code
Overview of work done
Removed commented out code
Removed unused parameters
Cleaned up todo comments
Overview of verification done
Same unit tests
Overview of integration done
N/A
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request