Update prisma schema according to discussion

[kachar]

https://miro.com/app/board/o9J_lvXbSGU=/?moveToWidget=3458764517165730780&cot=14

[github-actions]

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/yarn' failed with exit code 1

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.5% (-1.5% 🔻)	1189/1640
🔴	Branches	30.33% (-1.42% 🔻)	64/211
🔴	Functions	45.09% (-2.22% 🔻)	156/346
🟡	Lines	70.46% (-1.47% 🔻)	1028/1459

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🔴	... / transfer.service.ts	27.27% (-68.18% 🔻)	0% (-100% 🔻)	16.67% (-83.33% 🔻)	23.53% (-70.59% 🔻)

Test suite run failed

Failed tests: 0/119. Failed suites: 1/49.

  ● Test suite failed to run

    apps/api/src/transfer/transfer.controller.spec.ts:85:52 - error TS2345: Argument of type '({ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; })[]' is not assignable to parameter of type 'Transfer[] | PrismaPromise<Transfer[]>'.
      Type '({ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; })[]' is not assignable to type 'Transfer[]'.
        Type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; }' is not assignable to type 'Transfer'.
          Property 'tax' is missing in type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' but required in type 'Transfer'.

    85     prismaMock.transfer.findMany.mockResolvedValue(mockData)
                                                          ~~~~~~~~

      node_modules/.prisma/client/index.d.ts:317:3
        317   tax: number
              ~~~
        'tax' is declared here.
    apps/api/src/transfer/transfer.controller.spec.ts:96:54 - error TS2345: Argument of type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; }' is not assignable to parameter of type 'Transfer | Prisma__TransferClient<Transfer | null> | null'.
      Type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' is not assignable to type 'Transfer | Prisma__TransferClient<Transfer | null> | null'.
        Type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' is not assignable to type 'Transfer'.

    96     prismaMock.transfer.findUnique.mockResolvedValue(transfer)
                                                            ~~~~~~~~
    apps/api/src/transfer/transfer.controller.spec.ts:124:50 - error TS2345: Argument of type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; }' is not assignable to parameter of type 'Transfer | Prisma__TransferClient<Transfer>'.
      Type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' is not assignable to type 'Transfer | Prisma__TransferClient<Transfer>'.
        Type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' is not assignable to type 'Transfer'.

    124     prismaMock.transfer.create.mockResolvedValue(transfer)
                                                         ~~~~~~~~
    apps/api/src/transfer/transfer.controller.spec.ts:146:50 - error TS2345: Argument of type '{ reason: string; id: string; status: "initial"; currency: "BGN"; amount: number; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; }' is not assignable to parameter of type 'Transfer | Prisma__TransferClient<Transfer>'.
      Type '{ reason: string; id: string; status: "initial"; currency: "BGN"; amount: number; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' is not assignable to type 'Transfer | Prisma__TransferClient<Transfer>'.
        Property 'tax' is missing in type '{ reason: string; id: string; status: "initial"; currency: "BGN"; amount: number; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; }' but required in type 'Transfer'.

    146     prismaMock.transfer.update.mockResolvedValue({ ...transfer, reason: 'random' })
                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

      node_modules/.prisma/client/index.d.ts:317:3
        317   tax: number
              ~~~
        'tax' is declared here.
    apps/api/src/transfer/transfer.controller.spec.ts:159:50 - error TS2345: Argument of type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; }' is not assignable to parameter of type 'Transfer | Prisma__TransferClient<Transfer>'.

    159     prismaMock.transfer.update.mockResolvedValue(transfer)
                                                         ~~~~~~~~
    apps/api/src/transfer/transfer.controller.spec.ts:185:50 - error TS2345: Argument of type '{ id: string; status: "initial"; currency: "BGN"; amount: number; reason: string; targetDate: Date; documentId: string; approvedById: string; sourceCampaignId: string; targetCampaignId: string; sourceVaultId: string; targetVaultId: string; createdAt: Date; updatedAt: null; } | { ...; } | { ...; }' is not assignable to parameter of type 'Transfer | Prisma__TransferClient<Transfer>'.

    185     prismaMock.transfer.delete.mockResolvedValue(transfer)
                                                         ~~~~~~~~

Report generated by 🧪jest coverage report action from 45f494e