Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove UIKitNavigation dependency from SwiftUINavigation #194

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Remove UIKitNavigation dependency from SwiftUINavigation #194

merged 5 commits into from
Aug 6, 2024

Conversation

jc-paris
Copy link
Contributor

@jc-paris jc-paris commented Aug 6, 2024

SwiftUINavigation is currently depending on UIKitNavigation.

This seems strange to me so I tried to remove it. Unit test have passed so I'm proposing the change 🙂

stephencelis
stephencelis approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that was making the accidental assumption that SwiftUI exports UIKit, but that's not the case.

@stephencelis stephencelis merged commit 2101b07 into pointfreeco:main Aug 6, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jc-paris @stephencelis