Leader election #93
Leader election #93
Conversation
erikdubbelboer
force-pushed
the
leader-election-only
branch
4 times, most recently
from
24ce927 to
961df49
Compare
erikdubbelboer
force-pushed
the
leader-election-only
branch
from
961df49 to
c8612a4
Compare
Give each lobby a leader. A leader is a useful concept to have in many game types. Implementing leader election in the game itself is much harder. After this we can add support for the leader to be able to change the lobby data. For example making it private when a game starts.
erikdubbelboer
force-pushed
the
leader-election-only
branch
from
c8612a4 to
f2e5f33
Compare
| @@ -88,6 +86,28 @@ func (i *TimeoutManager) Disconnected(ctx context.Context, p *Peer) { | |||
| err := i.Store.TimeoutPeer(ctx, p.ID, p.Secret, p.Game, lobbies) | |||
| if err != nil { | |||
| logger.Error("failed to record timeout peer", zap.Error(err)) | |||
| } else { | |||
There was a problem hiding this comment.
Do we maybe wanna do leaderElection anyway, even if the TimeoutPeer failed?
There was a problem hiding this comment.
If TimeoutPeer fails, the peer won't have been inserted into timeouts and DoLeaderElection will just keep it as the current leader if it is.
There was a problem hiding this comment.
And most likely if TimeoutPeer the database has issues and DoLeaderElection will also fail.
erikdubbelboer
force-pushed
the
leader-election-only
branch
from
61ba7ee to
7af5491
Compare
| @@ -67,6 +67,13 @@ type JoinedPacket struct { | |||
| LobbyInfo stores.Lobby `json:"lobbyInfo"` | |||
| } | |||
|
|
|||
| type LeaderPacket struct { | |||
| Type string `json:"type"` | |||
|
|
|||
There was a problem hiding this comment.
Idea: Should this packet also contain the lobby it's about?
There was a problem hiding this comment.
Since you can currently only be in 1 lobby that wouldn't make sense.
There was a problem hiding this comment.
Fair, I figured it would make it forward compatible. But I guess we can always add it
Give each lobby a leader. A leader is a useful concept to have in many game types. Implementing leader election in the game itself is much harder.
After this we can add support for the leader to be able to change the lobby data. For example making it private when a game starts.