Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add script to copy proto and ts client files from poktroll #24

Conversation

Alann27
Copy link
Contributor

@Alann27 Alann27 commented Oct 24, 2024

Summary

  • Added script to copy the proto files from poktroll and the typescript files generated by ignite.

Details

  • We need the typescript files generated by ignite because when a param is updated, an encoded MsgUpdateParam is emitted inside of a message of type /cosmos.authz.v1beta1.MsgExec. To decode the MsgUpdateParam, the typescript files are required.

Issue

We need to keep updated the poktroll proto files when they are updated on the poktroll repo. This script automates this process.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@Alann27 Alann27 marked this pull request as ready for review October 25, 2024 15:10
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @Alann27 thanks for tackling this automation! 💪 🚀


rm -rf ${DIR}/../proto/poktroll
mkdir -p ${DIR}/../proto/poktroll
cp -TR poktroll/proto/poktroll/ ${DIR}/../proto/poktroll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#PUC

Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alann27 🙏 - this looks great! 🚀

}

# Remove the temp directory on exit
trap cleanup EXIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@jorgecuesta jorgecuesta merged commit bcf7244 into pokt-network:main Oct 28, 2024
4 checks passed
@jorgecuesta jorgecuesta deleted the chore/add-script-to-copy-proto-and-client-files branch October 28, 2024 14:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants