fix: Validate column names in unique() for empty DataFrames
#20411
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biswas-N
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20411 +/- ##
=======================================
Coverage 79.02% 79.03%
=======================================
Files 1563 1563
Lines 220587 220594 +7
Branches 2502 2502
=======================================
+ Hits 174324 174336 +12
+ Misses 45689 45684 -5
Partials 574 574 ☔ View full report in Codecov by Sentry. |
|
These error should be raised during conversion to IR, not at the implementation level. |
|
@ritchie46 thanks for having a look. I am new to contributing to |
ritchie46
reviewed
Dec 24, 2024
Ensures that column names in the subset parameter are validated even when the dataframe is empty, maintaining consistent behavior with non-empty dataframes.
Add test cases to verify that unique() properly handles invalid column names in subset parameter for both empty and non-empty dataframes.
Biswas-N
force-pushed
the
fix/unique_raises_for_bad_subset
branch
from
c982905 to
7c62814
Compare
Refactored column validation to use a `for` loop with `map_err` instead of `try_for_each`. This enhances readability and maintains consistent error handling when checking if subset columns exist in the dataframe during conversion.
ritchie46
changed the title
unique() for empty DataFramesunique() for empty DataFrames
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
unique() functionin Polars does not raise aColumnNotFoundErrorwhen called on an empty DataFrame with an unknown subset of column names. The changes ensure that column names in the subset are validated before proceeding, thereby raising the appropriate exception.Changes Made:
Rust:
UniqueExecexecutor to check the subset of column names provided exists in an empty DataFrame.Python Tests:
test_unique_with_bad_subsetintest_unique.pyto handle scenarios whereSubset column name(s) do not exist.ColumnNotFoundErrorwith appropriate message.Linked Issue:
Closes #20209
Checklist:
mainbranch.pytestfor Python tests.