Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: Don't always take all data buffers when gathering views #20435

Merged
merged 7 commits into from
Dec 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Dec 24, 2024

Always blindly taking all data buffers of all input chunks leads to exponential behavior in the new join. Now if there is more than one chunk we deduplicate and only take those data buffers we actually reference.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Dec 24, 2024
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #20435 will not alter performance

Comparing orlp:dedup-gather (39ac18b) with main (f213c36)

Summary

✅ 41 untouched benchmarks

@ritchie46 ritchie46 merged commit c6769c2 into pola-rs:main Dec 24, 2024
20 checks passed
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 80.70175% with 33 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (2ae01fb) to head (39ac18b).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...tes/polars-ops/src/chunked_array/gather/chunked.rs 80.70% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20435      +/-   ##
==========================================
+ Coverage   78.98%   79.01%   +0.02%     
==========================================
  Files        1562     1562              
  Lines      220103   220221     +118     
  Branches     2486     2488       +2     
==========================================
+ Hits       173855   173997     +142     
+ Misses      45675    45651      -24     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants