Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: Remove prepare_series for gather kernels #20439

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Dec 24, 2024

For left-hand sides with many chunks (most notably in the new-streaming join) the prepare_series was very expensive and it's not necessary at all (we just have to match on a couple more logical types).

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Dec 24, 2024
@ritchie46 ritchie46 merged commit 0ed4b4c into pola-rs:main Dec 24, 2024
20 checks passed
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 54.76190% with 38 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (c6769c2) to head (88754ef).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...tes/polars-ops/src/chunked_array/gather/chunked.rs 54.76% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20439      +/-   ##
==========================================
- Coverage   79.01%   79.00%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      220290   220340      +50     
  Branches     2488     2488              
==========================================
+ Hits       174055   174079      +24     
- Misses      45662    45688      +26     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants