perf: Re-enable common subplan elim for new-streaming engine #20443
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
orlp
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
orlp
force-pushed
the
comm-subplan-elim
branch
from
120f5d5 to
b0206db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20443 +/- ##
=======================================
Coverage 79.00% 79.00%
=======================================
Files 1563 1563
Lines 220338 220336 -2
Branches 2488 2488
=======================================
+ Hits 174068 174073 +5
+ Misses 45697 45690 -7
Partials 573 573 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Dec 25, 2024
| @@ -86,6 +86,7 @@ pub fn lower_ir( | |||
| phys_sm: &mut SlotMap<PhysNodeKey, PhysNode>, | |||
| schema_cache: &mut PlHashMap<Node, Arc<Schema>>, | |||
| expr_cache: &mut ExprCache, | |||
| cache_nodes: &mut PlHashMap<usize, PhysNodeKey>, | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.