Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: Use different binview dedup strategy depending on chunks ratio #20451

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Dec 25, 2024
@ritchie46 ritchie46 changed the title perf: Take different binview dedup strategy depending on chunks ratio perf: Use different binview dedup strategy depending on chunks ratio Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 45.90164% with 66 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (a6fffd4) to head (d34ca0f).

Files with missing lines Patch % Lines
...tes/polars-ops/src/chunked_array/gather/chunked.rs 45.90% 66 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20451      +/-   ##
==========================================
+ Coverage   79.00%   79.01%   +0.01%     
==========================================
  Files        1563     1563              
  Lines      220449   220553     +104     
  Branches     2488     2488              
==========================================
+ Hits       174157   174271     +114     
+ Misses      45719    45709      -10     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit aaacdbe into main Dec 26, 2024
41 of 43 checks passed
@ritchie46 ritchie46 deleted the binview branch December 26, 2024 10:02
@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants