Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Allow more join lossless casting #20474

Merged
merged 2 commits into from
Dec 27, 2024
Merged

feat: Allow more join lossless casting #20474

merged 2 commits into from
Dec 27, 2024

Conversation

ritchie46
Copy link
Member

Also lossless cast expression that aren't only column references.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 27, 2024
@ritchie46 ritchie46 merged commit 0a7814b into main Dec 27, 2024
19 checks passed
@ritchie46 ritchie46 deleted the join branch December 27, 2024 09:42
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (8b3afb7) to head (53cd222).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/conversion/join.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20474   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files        1563     1563           
  Lines      220562   220570    +8     
  Branches     2490     2490           
=======================================
+ Hits       174206   174225   +19     
+ Misses      45783    45772   -11     
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants