Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: Remove predicate from IR::DataFrame #20492

Merged
merged 1 commit into from
Dec 29, 2024
Merged

perf: Remove predicate from IR::DataFrame #20492

merged 1 commit into from
Dec 29, 2024

Conversation

ritchie46
Copy link
Member

Simplifies IR, saves a lowering step in streaming and ensures that the in-memory engine can parallelize if it wants to.

First solution for #20475

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Dec 29, 2024
Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #20492 will degrade performances by 55.9%

Comparing filter (b743532) with main (f43a7d4)

Summary

❌ 8 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main filter Change
test_pdsh_q12 7.5 ms 10.2 ms -25.72%
test_pdsh_q13 10.6 ms 24 ms -55.9%
test_pdsh_q14 3.4 ms 4.7 ms -26.61%
test_pdsh_q15 3.1 ms 4.5 ms -30.24%
test_pdsh_q16 7.8 ms 14.7 ms -46.66%
test_pdsh_q3 7.5 ms 10.6 ms -29.53%
test_pdsh_q4 5.9 ms 8.1 ms -27.47%
test_pdsh_q6 3.7 ms 5.5 ms -32.65%

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (f43a7d4) to head (b743532).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20492      +/-   ##
==========================================
- Coverage   79.02%   79.01%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      220596   220532      -64     
  Branches     2492     2492              
==========================================
- Hits       174317   174249      -68     
- Misses      45706    45710       +4     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9a44c02 into main Dec 29, 2024
27 checks passed
@ritchie46 ritchie46 deleted the filter branch December 29, 2024 10:40
@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants